bfg: take into account l2 keystones that are more final than 100 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: bfg
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom,
joshuasing and
AL-CT
there is a bug in the postgres query that only takes into account the first 100 btc blocks when determining effective height, so if a keystone was published older than the first 100 it wouldn't get counted in effective height. remove this clause; I am not sure why it was introduced but it is likely fallout from when trying to optimize these queries add a test that should have caught this
ClaytonNorthey92
force-pushed
the
clayton/op-geth-testing-2
branch
from
695e4c9 to
9ddaad9
Compare
|
meh one bug in my change...fixing |
joshuasing
changed the title
joshuasing
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
there is a bug in the postgres query that only takes into account the first 100 bitcoin blocks when determining effective height, so if a keystone was published older than the first 100 it wouldn't get counted in effective height.
remove this clause; I am not sure why it was introduced but it is likely fallout from when trying to optimize these queries
add a test that should have caught this
Changes
see summary