tbc: use proper database for index hashes #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es into index functions
marcopeereboom
added
type: bug
marcopeereboom
changed the title
1 task
ClaytonNorthey92
requested changes
Feb 19, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joshuasing
reviewed
Feb 20, 2025
joshuasing
requested changes
Feb 20, 2025
joshuasing
requested changes
Feb 20, 2025
…vious block from the last processed block
AL-CT
approved these changes
Feb 20, 2025
joshuasing
approved these changes
Feb 20, 2025
ClaytonNorthey92
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For performance reasons we ended up updating index hashes in metadata. This turned out to be a mistake because op-geth punished us by killing tbc in between the index and the index hash update.
Changes
Move index hashes into the proper database thus making it part of the database transaction thus making it atomic.