-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: add hemictl image #407
base: main
Are you sure you want to change the base?
Conversation
add hemictl image for hemictl via regular Docker and goreleaser updated goreleaser workflow to include hemictl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor date wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
FWIW I have removed the need to for this to restart indexers. You can now simply rm the directory you want reindexed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you also need to add a binary
for hemictl
, otherwise it won't be built or made available when GoReleaser is creating the Docker images (COPY hemictl /usr/local/bin/hemictl
).
The popmd
binary could be used as an example.
Docs: https://goreleaser.com/customization/builds/go/?h=binary
# which can be found in the LICENSE file. | ||
|
||
# Build stage | ||
FROM golang:1.23-alpine3.20@sha256:d0b31558e6b3e4cc59f6011d79905835108c919143ebecc58f35965bf79948f4 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking - The latest available golang
tag is 1.24.0-alpine3.21
(sha256:2d40d4fc278dad38be0777d5e2a88a2c6dee51b0b29c97a764fc6c6a11ca893c
), we should probably upgrade all of the base images (although that could be a separate PR): https://hub.docker.com/layers/library/golang/1.24.0-alpine3.21/images/sha256-32ece9b4650da07c5e92744894d2fb9e857729466eeb9e38c99f7ddec83803ec
Summary
add hemictl image for hemictl via regular Docker and goreleaser
updated goreleaser workflow to include hemictl
Changes
see summary