tbc: fix typo #402
Merged
tbc: fix typo #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
added
size: XS
joshuasing
approved these changes
Feb 12, 2025
AL-CT
approved these changes
Feb 12, 2025
marcopeereboom
added a commit
that referenced
this pull request
Feb 12, 2025
Not sure how this snuck into main.
marcopeereboom
added a commit
that referenced
this pull request
Feb 17, 2025
* Introduce flushing strategy to the database. We can estimate pretty accurately which transactions need a compaction and which don't. The issue at hand is that very small transactions may not flush quickly enough leading to reading of stale data. This may need some additional tinkering but try this for the time being. * lint goop * Fix typo. (#402) Not sure how this snuck into main. * typo * typpo * FUCK YOU LEVELDB * Fix prints and remove XXX * Yikes fix a bad bug in keystone indexer. We MUST delete the cache in the database function and NOT use continue to skip over records we don't like. This led to continues growth of the keystone cache and improper flushing. Tests aren't passing and need to be investigated. * typo * Leave not for maitainers how we reindex the last block always * Leave note for maitainers how we reindex the last block always * fixed keystone specific tests * use maps package for clone * revert keystone index hash back so tests pass * Dedup next block from all indexers so that we can call it elsewhere as well. * More dedup of code and simplification * Moar smol * Oops! fix a bug in processKeystones; explanation in code * made keystone testing more robust in fork tests * Add some block tests * added old fork tests back * linter crap * make keystone fork tests a bit more organized --------- Co-authored-by: AL-CT <antoniomartins@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this snuck into main.
Summary
Typo that broke the tree. Sorry about that.
Changes