Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing endpoints in tasks-svc #768

Merged
merged 42 commits into from
Sep 5, 2024
Merged

Conversation

PaulKalho
Copy link
Member

@PaulKalho PaulKalho commented May 27, 2024

Which issues does this pull request close?

closes #703

I had to alter the proto definition of getPatientListResponse a bit, now we don't need two Patient types

@PaulKalho PaulKalho self-assigned this May 27, 2024
@PaulKalho PaulKalho force-pushed the issue/703-task-missing-endpoints branch from ec48b72 to 845a018 Compare May 27, 2024 22:08
@PaulKalho PaulKalho marked this pull request as ready for review May 27, 2024 23:46
@PaulKalho PaulKalho requested a review from a team as a code owner May 27, 2024 23:46
@PaulKalho PaulKalho requested review from FoseFx and Paul-B98 and removed request for a team May 27, 2024 23:46
@PaulKalho PaulKalho marked this pull request as draft August 14, 2024 16:23
@PaulKalho PaulKalho marked this pull request as ready for review August 14, 2024 16:32
libs/hwes/event.go Outdated Show resolved Hide resolved
proto/services/tasks_svc/v1/task_svc.proto Outdated Show resolved Hide resolved
services/tasks-svc/schema.sql Outdated Show resolved Hide resolved
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response of GetPatientDetails. Take a look at the assigned_user_id. Same for GetPatientList and GetTasksByPatient.

{
    "tasks": [
        {
            "subtasks": [],
            "id": "14724cf7-175b-4804-ba90-e922d4603745",
            "name": "asd",
            "description": "test",
            "status": "TASK_STATUS_IN_PROGRESS",
            "patient_id": "",
            "public": false,
            "assigned_user_id": "00000000-0000-0000-0000-000000000000"
        }
    ],
    "id": "643afb22-c8f6-4dd8-909b-303fa58cc3ad",
    "human_readable_identifier": "asd",
    "notes": "asd",
    "is_discharged": false
}

Cannot test GetPatientByBed, GetPatientByBed, GetPatientAssignmentByWard because I cannot create beds and wards.

@PaulKalho PaulKalho merged commit 0b57536 into main Sep 5, 2024
42 checks passed
@PaulKalho PaulKalho deleted the issue/703-task-missing-endpoints branch September 5, 2024 13:11
@PaulKalho PaulKalho restored the issue/703-task-missing-endpoints branch September 5, 2024 13:11
@FoseFx FoseFx deleted the issue/703-task-missing-endpoints branch October 20, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing endpoints in tasks-svc
2 participants