sqlc: beds, rooms, and patients #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoseFx
changed the title
FoseFx
added
the
is-blocked
Merged
FoseFx
changed the title
FoseFx
force-pushed
the
issue/562-sqlc-beds
branch
from
1f9790f to
d678a15
Compare
FoseFx
removed
the
is-blocked
FoseFx
force-pushed
the
issue/562-sqlc-beds
branch
from
2df9631 to
af5ec5e
Compare
|
Done with Phase I: All tests are passing. |
|
Phase II done: TODOs are done. R4R |
FoseFx
requested review from
felixevers and
DasProffi
and removed request for
a team
Merged
MaxSchaefer
reviewed
Dec 6, 2023
MaxSchaefer
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Looks good so far.
Found one error in Endpoint GetRecentPatients:
failed to encode args[0]: unable to encode []uuid.UUID{uuid.UUID{0x6a, 0x7a, 0x8d, 0xfe, 0x5f, 0x8f, 0x4b, 0x7f, 0xa9, 0xf6, 0xd, 0xf0, 0xd2, 0xbf, 0x14, 0x23}, uuid.UUID{0xc1, 0xf7, 0x6e, 0xd5, 0xcd, 0x56, 0x48, 0xbe, 0x96, 0x5, 0x7f, 0x6b, 0x6, 0x4d, 0xcb, 0x33}, uuid.UUID{0x9b, 0xa7, 0x7, 0x3d, 0x94, 0xc6, 0x43, 0x35, 0x99, 0xd7, 0x1b, 0x10, 0xc6, 0xf8, 0x91, 0x51}, uuid.UUID{0x97, 0xf0, 0xd2, 0x87, 0x34, 0x98, 0x41, 0x4c, 0xba, 0xb9, 0xf, 0x34, 0x1b, 0x32, 0x8a, 0xe4}} into binary format for uuid (OID 2950): cannot find encode plan
FoseFx
force-pushed
the
issue/562-sqlc-beds
branch
from
a2fec36 to
2e9913b
Compare
MaxSchaefer
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues does this pull request close?
Progresses #563, #562, #570
Removes beds, rooms and patients repos (now generated using sqlc) and all direct usage of the corresponding models.
BREAKING: makes GetPatientList's Task's AssignedUserID optional.
Affected by this PR:
Italic Endpoints have integration tests