Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MockRender): the host element doesn't have __ngContext__ attribute anymore #3811 #3830

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

satanTime
Copy link
Member

NOTE: If you use jest snapshots it might require to update them and remove the __ngContext__ attribute from mock-render nodes.

closes #3811

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (0138df7) compared to base (00532f3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3830   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          221       221           
  Lines         4565      4569    +4     
  Branches      1044      1044           
=========================================
+ Hits          4565      4569    +4     
Impacted Files Coverage Δ
...g-mocks/src/lib/mock-render/func.create-wrapper.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…te anymore help-me-mom#3811

NOTE: If you use jest snapshots it might require to update them and remove the `__ngContext__` attribute from `mock-render` nodes.
@satanTime satanTime merged commit fc74684 into help-me-mom:master Oct 13, 2022
@satanTime satanTime deleted the issues/3811 branch October 13, 2022 10:03
@satanTime
Copy link
Member Author

v14.3.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Test fails if executed independently '__ngContext__={[Function Number]}' vs '__ngContext__="0"'
1 participant