Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find ng-container #289

Closed
15 tasks done
satanTime opened this issue Feb 4, 2021 · 2 comments · Fixed by #304
Closed
15 tasks done

find ng-container #289

satanTime opened this issue Feb 4, 2021 · 2 comments · Fixed by #304
Assignees
@satanTime
Labels
released v11.8.0

Comments

@satanTime
Copy link
Member

satanTime commented Feb 4, 2021 •
edited
Loading

add a reveal function which would find debug elements of ng-container.
also reveal and find should support look up in ng-container too, although it is a comment element.

  • ngMocks.crawl(debugElement, callback(currentDebugElement, parentDebugElement?))
  • ngMocks.reveal and ngMocks.revealAll
  • (impossible) extend ngMocks.find and ngMocks.findAll to support ng-content nodes ( simply call itself recursively
  • extend ngMocks.findInstance and ngMocks.findInstances to use ngMocks.crawl
  • extend ngMocks.formatHtml to support ng-content (simply join childrens' innerHTML)
  • share all callback functions for ngMocks.crawl
  • docs about ngMocks.crawl
  • (impossible) docs about ngMocks.find and ngMocks.findAll
  • docs about ngMocks.findInstance and ngMocks.findInstances
  • docs about ngMocks.formatHtml
  • docs about all callback functions for ngMocks.crawl
  • docs about ngMocks.reveal and ngMocks.revealAll
  • check if we can assert html right on a debug element of a TemplateRef
  • update examples with sources
  • check e2e examples (can be simplified?)
@satanTime satanTime changed the title find ng-content find ng-container Feb 12, 2021
@satanTime satanTime self-assigned this Feb 19, 2021
This was referenced Feb 21, 2021
Closed
Merged
@satanTime
Copy link
Member Author

Fix todo links

satanTime added a commit that referenced this issue Feb 25, 2021
@satanTime
feat: find ng-container via ngMocks.reveal and revealAll
71390b2 
closes #289
satanTime added a commit that referenced this issue Feb 25, 2021
@satanTime
feat: respect of virtual dom with ngMocks.crawl
030b29f 
closes #289
satanTime added a commit that referenced this issue Feb 25, 2021
@satanTime
docs: new features
8aa394a 
closes #289
@satanTime
Copy link
Member Author

v11.8.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satanTime satanTime

Labels
released v11.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

find ng-container satanTime/ng-mocks
1 participant
@satanTime