Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-359: add extensions to imported middlewares #373

Merged
merged 1 commit into from
Jul 22, 2022
Merged

issue-359: add extensions to imported middlewares #373

merged 1 commit into from
Jul 22, 2022

Conversation

Pauline-sh
Copy link
Contributor

@EvanHahn
Copy link
Member

Thanks so much for this. I'll take a look soon (probably not today).

@EvanHahn EvanHahn merged commit 4e55f49 into helmetjs:main Jul 22, 2022
@EvanHahn
Copy link
Member

I just merged this but realized there's a problem with it. I'll be making some tweaks.

@EvanHahn EvanHahn mentioned this pull request Jul 22, 2022
Closed
@EvanHahn
Copy link
Member

I left a comment in the original issue explaining why this solution doesn't (completely) work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pauline-sh @EvanHahn