-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete to XFrameOptionsOptions #322
Conversation
Changes the XFrameOptionsOptions to let typescript suggest "DENY" and "SAMEORIGIN" in autocomplete with the trick in microsoft/TypeScript#29729
Thanks for the pull request. It might be a few weeks before I get to it, but it's on my list. |
Thanks for your work here. I know that some people have these options as configuration files, so they want to pass strings and not more specific types. Does this still work if you pass a variable of type Also, if we do this, I think it's worth adding some kind of explainer comment. (I'm away from my computer at the moment, otherwise I'd test this myself!) |
Yes, at type check this is equivalent to just |
This is also equivalent to I agree about adding comments, but not sure how detailed it should be. |
There is a rule in |
Thanks for the detailed answer.
I'll take another look in the next few weeks.
|
I haven't forgotten about this but haven't had time to look at it yet. It's still on my list! |
I made a couple of small changes and merged this in 2f13523. As before, let me know if you'd like to be added to the contributors page. |
Changes the XFrameOptionsOptions to let typescript suggest "DENY" and
"SAMEORIGIN" in autocomplete with the trick in
microsoft/TypeScript#29729