Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/redis] Update labelling strategy #9332

Closed
wants to merge 2 commits into from
Closed

[stable/redis] Update labelling strategy #9332

wants to merge 2 commits into from

Conversation

yurrriq
Copy link
Collaborator

@yurrriq yurrriq commented Nov 16, 2018

What this PR does / why we need it:

Checklist

  • DCO signed
  • Chart Version bumped

Signed-off-by: Eric Bailey <e.bailey@sportradar.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yurrriq
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: juan131

If they are not already assigned, you can assign the PR to them by writing /assign @juan131 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @yurrriq. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- Use [recommended labels][1] via newly created named templates
- Rename a few labels to be more specific
    - `role: metrics` -> `app.kubernetes.io/component: metrics`
    - `role: master` -> `redis.io/role: master`
    - `role: slave` -> `redis.io/role: slave`

[1]: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Signed-off-by: Eric Bailey <e.bailey@sportradar.com>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2018
@yurrriq
Copy link
Collaborator Author

yurrriq commented Nov 16, 2018

/assign @juan131

@desaintmartin
Copy link
Collaborator

Should we discuss this during the next meeting? #7696 has been closed due to lack of activity.

@yurrriq
Copy link
Collaborator Author

yurrriq commented Nov 17, 2018

I could join the discussion on 11/29.

@yurrriq yurrriq closed this Nov 17, 2018
@yurrriq yurrriq reopened this Nov 17, 2018
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2018
Copy link
Contributor

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a breaking change for people operating Redis because the matchLabels and volume lablels change. A painful change just for labels is one I'm not sure I want to put forth.

It may make more sense to do this when it moves to the distributed search and some other large changes land.

{{ include "redis.instance-name" . }}
app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
helm.sh/chart: {{ include "redis.chart" . | quote }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a neat method to avoid repeating the same things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this could be made the default?

@stale
Copy link

stale bot commented Dec 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2018
@yurrriq yurrriq closed this Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants