Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/gogs] add install lock opportunity #9315

Merged
merged 7 commits into from
Nov 26, 2018
Merged

[incubator/gogs] add install lock opportunity #9315

merged 7 commits into from
Nov 26, 2018

Conversation

obeyler
Copy link
Contributor

@obeyler obeyler commented Nov 16, 2018

/assign @responsible
/assign @cheyang

What this PR does / why we need it:

This PR propose to allow launch gogs with INSTALL_LOCK=false
The aim of this is to be able install a gogs automatically with self register option disactivated and be able to create an admin user.

If you want that you just have to install helm with install_lock= false, create an user with a curl on /install path, change the configmap to have install_lock = true and recreate the gogs pod to reload the config map

Which issue this PR fixes

fixes : #6942 , #9278

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Add opportunity to start with install mode

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
increase chart version

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Add installLock  parameter

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
fixup the typo

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
@k8s-ci-robot
Copy link
Contributor

@obeyler: GitHub didn't allow me to assign the following users: responsible.

Note that only helm members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @responsible
/assign @cheyang

What this PR does / why we need it:

This PR propose to allow launch gogs with INSTALL_LOCK=false
The aim of this is to be able install a gogs automatically with self register option disactivated and be able to create an admin user.

If you want that you just have to install helm with install_lock= false, create an user with a curl on /install path, change the configmap to have install_lock = true and recreate the gogs pod to reload the config map

Which issue this PR fixes

fixes : #6942 , #9278

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @obeyler. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2018
@prydonius
Copy link
Member

@obeyler are you interested in taking over maintainership of this chart? Or do you know someone else who might be interested?

@obeyler
Copy link
Contributor Author

obeyler commented Nov 16, 2018

@prydonius I just want to contribute a little on it. I think I don't know enough gogs product to become the maintainer.

@prydonius
Copy link
Member

cc @helm/charts-maintainers what do you think we should do here? How can we accept a change for a chart that is no longer maintained?

@mattfarina
Copy link
Contributor

I'm ok with the change as long as tests are passing. I understand it's a little to add to this PR but I think we need them passing if we want to take on contributions.

@prydonius
Copy link
Member

cc @responsible @tvon @sonnyvan @kevinschumacher @jpds @gyliu513 @fuhbar @cheyang @AdamDang as other contributors to this chart are any of you interested in being listed as a maintainer?

@mochi99999
Copy link
Contributor

@prydonius I've only bumped the versions for gogs so I will pass. Thank you

@tvon
Copy link
Contributor

tvon commented Nov 20, 2018

I do not actively use this so I am probably not a good candidate to be listed as a maintainer.

@gyliu513
Copy link
Contributor

Thanks @prydonius , I also do not contribute to this chart much, so I will pass as well.

@obeyler
Copy link
Contributor Author

obeyler commented Nov 23, 2018

@prydonius @responsible @tvon @sonnyvan @kevinschumacher @jpds @gyliu513 @fuhbar @cheyang @AdamDang
As nobody want to be maintainer of gogs helm chart I propose to become it

@obeyler obeyler closed this Nov 23, 2018
@obeyler obeyler reopened this Nov 23, 2018
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 23, 2018
Add owner file

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
@helm-bot helm-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2018
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2018
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 23, 2018
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2018
@obeyler
Copy link
Contributor Author

obeyler commented Nov 26, 2018

@prydonius @responsible @tvon @sonnyvan @kevinschumacher @jpds @gyliu513 @fuhbar @cheyang @AdamDang
As nobody want to be maintainer of gogs helm chart I propose to become it

@prydonius
Copy link
Member

@obeyler thanks a lot!

/ok-to-test

/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: obeyler, prydonius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 88975db into helm:master Nov 26, 2018
bendrucker pushed a commit to bendrucker/charts that referenced this pull request Nov 26, 2018
* Update configmap.yaml

Add opportunity to start with install mode

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

increase chart version

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

Add installLock  parameter

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

fixup the typo

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Create OWNERS

Add owner file

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Signed-off-by: Ben Drucker <bvdrucker@gmail.com>
@obeyler obeyler deleted the incubator-gogs-add-install-lock-opportunity branch November 26, 2018 21:15
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this pull request Nov 30, 2018
* Update configmap.yaml

Add opportunity to start with install mode

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

increase chart version

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

Add installLock  parameter

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

fixup the typo

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Create OWNERS

Add owner file

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
davidkarlsen pushed a commit to davidkarlsen/charts that referenced this pull request Dec 2, 2018
* Update configmap.yaml

Add opportunity to start with install mode

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

increase chart version

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

Add installLock  parameter

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

fixup the typo

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Create OWNERS

Add owner file

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this pull request Dec 11, 2018
* Update configmap.yaml

Add opportunity to start with install mode

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

increase chart version

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

Add installLock  parameter

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

fixup the typo

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Create OWNERS

Add owner file

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
* Update configmap.yaml

Add opportunity to start with install mode

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

increase chart version

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

Add installLock  parameter

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update values.yaml

fixup the typo

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Create OWNERS

Add owner file

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>

* Update Chart.yaml

Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[incubator/gogs] serviceDisableRegistration: false and user creation
9 participants