Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/fluentd] Promote fluentd to stable #7182

Closed
wants to merge 3 commits into from
Closed

[incubator/fluentd] Promote fluentd to stable #7182

wants to merge 3 commits into from

Conversation

rendhalver
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rendhalver
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattfarina

If they are not already assigned, you can assign the PR to them by writing /assign @mattfarina in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
paulczar
paulczar suggested changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@paulczar paulczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine to me, just needs to be rebased to solve the merge conflict.

@rendhalver
Copy link
Collaborator Author

Thanks @paulczar I will get that sorted soon.

@paulczar
Copy link
Collaborator

paulczar commented Sep 6, 2018

Since we're promoting to stable we should version it to 1.0.0

@stale
Copy link

stale bot commented Oct 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2018
rendhalver pushed a commit to powerhome/kubernetes-charts that referenced this pull request Oct 15, 2018
Promote Fluentd to stable
5698367 
Redo of helm#7182

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
@rendhalver rendhalver mentioned this pull request Oct 15, 2018
Merged
3 tasks
@rendhalver
Copy link
Collaborator Author

Closing in favour of #8477

@rendhalver rendhalver closed this Oct 15, 2018
@rendhalver rendhalver deleted the promote-fluentd-to-stable branch October 15, 2018 17:37
k8s-ci-robot pushed a commit that referenced this pull request Oct 16, 2018
@rendhalver @k8s-ci-robot
Promote Fluentd to stable (#8477)
4f88c32 
* Promote Fluentd to stable

Redo of #7182

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Increment version for fluentd

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
darioblanco pushed a commit to minddocdev/charts that referenced this pull request Oct 22, 2018
@rendhalver
Promote Fluentd to stable (helm#8477)
d95c897 
* Promote Fluentd to stable

Redo of helm#7182

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Increment version for fluentd

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
emas80 pushed a commit to faceit/charts that referenced this pull request Oct 24, 2018
@rendhalver @emas80
Promote Fluentd to stable (helm#8477)
973cab1 
* Promote Fluentd to stable

Redo of helm#7182

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Increment version for fluentd

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@rendhalver @Jnig
Promote Fluentd to stable (helm#8477)
a0de799 
* Promote Fluentd to stable

Redo of helm#7182

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Increment version for fluentd

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@rendhalver @wgiddens
Promote Fluentd to stable (helm#8477)
2bfa869 
* Promote Fluentd to stable

Redo of helm#7182

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Increment version for fluentd

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulczar paulczar paulczar requested changes

@scottrigby scottrigby Awaiting requested review from scottrigby

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rendhalver @k8s-ci-robot @paulczar @mattfarina