Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Fix Fluentd hanging https://github.com/fluent/fluentd/issues/1630 #5511

Merged
merged 4 commits into from
Jun 8, 2018
Merged

Fix Fluentd hanging https://github.com/fluent/fluentd/issues/1630 #5511

merged 4 commits into from
Jun 8, 2018

Conversation

mfornasa
Copy link
Contributor

What this PR does / why we need it: Fix fluentd-cloudwatch hanging as described in fluent/fluentd#1630.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #5510

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2018
@mfornasa
Copy link
Contributor Author

/assign @unguiculus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 11, 2018
@unguiculus
Copy link
Member

Please bump the chart version.

@mfornasa mfornasa force-pushed the fluentd-cloudwatch/fix-collector branch from 3beb053 to 026ea75 Compare May 17, 2018 19:50
@mfornasa
Copy link
Contributor Author

@unguiculus done

@unguiculus
Copy link
Member

Please check CircleCI which is still failing.

@mfornasa mfornasa force-pushed the fluentd-cloudwatch/fix-collector branch from 026ea75 to f6e9d08 Compare May 17, 2018 20:23
@mfornasa mfornasa force-pushed the fluentd-cloudwatch/fix-collector branch 2 times, most recently from 92d7d77 to f519660 Compare May 17, 2018 20:31
@mfornasa
Copy link
Contributor Author

Fixed and rebased to master.

@unguiculus
Copy link
Member

cc @jmcarp @icereval @kenden

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfornasa, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 98ec381 into helm:master Jun 8, 2018
@whereisaaron whereisaaron mentioned this pull request Jun 15, 2018
Closed
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
@mfornasa @or1can
Fix Fluentd hanging fluent/fluentd#1630 (helm#5511)
ad5dd06 
* fluentd-cloudwatch: Fix Fluentd hanging
fluent/fluentd#1630

* Update Chart.yaml
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
@mfornasa
Fix Fluentd hanging fluent/fluentd#1630 (helm#5511)
8ee41f8 
* fluentd-cloudwatch: Fix Fluentd hanging
fluent/fluentd#1630

* Update Chart.yaml

Signed-off-by: voron <av@arilot.com>
@alexanderkjeldaas alexanderkjeldaas mentioned this pull request Sep 22, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[incubator/fluentd-cloudwatch] Fluentd stop processing logs after ~ 10 minutes
3 participants
@mfornasa @k8s-ci-robot @unguiculus