Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/external-dns] Added ServiceAccount annotations #16730

Merged

Conversation

micahhausler
Copy link
Contributor

Signed-off-by: Micah Hausler mhausler@amazon.com

What this PR does / why we need it:

Adds support for configurable service account annotations. This will be used for AWS's IAM for Service Accounts (aws/containers-roadmap#23).

Which issue this PR fixes

N/A

Special notes for your reviewer:

This is a non-breaking change that will facilitate IAM for Service Accounts once kubernetes-sigs/external-dns#1172 lands in a release

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 30, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @micahhausler. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2019
@carrodher
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2019
@micahhausler micahhausler force-pushed the stable/external-dns/sa-annotations branch from 2fd6a61 to c8cd235 Compare September 4, 2019 22:27
@micahhausler
Copy link
Contributor Author

/test pull-charts-e2e

Signed-off-by: Micah Hausler <mhausler@amazon.com>
@micahhausler micahhausler force-pushed the stable/external-dns/sa-annotations branch from c8cd235 to 7e9bae5 Compare September 4, 2019 22:30
@carrodher
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carrodher, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4853e73 into helm:master Sep 5, 2019
@micahhausler micahhausler deleted the stable/external-dns/sa-annotations branch September 5, 2019 17:24
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
Signed-off-by: Micah Hausler <mhausler@amazon.com>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
Signed-off-by: Micah Hausler <mhausler@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants