-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/external-dns] Added ServiceAccount annotations #16730
[stable/external-dns] Added ServiceAccount annotations #16730
Conversation
Hi @micahhausler. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
2fd6a61
to
c8cd235
Compare
/test pull-charts-e2e |
Signed-off-by: Micah Hausler <mhausler@amazon.com>
c8cd235
to
7e9bae5
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carrodher, micahhausler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Micah Hausler <mhausler@amazon.com>
Signed-off-by: Micah Hausler <mhausler@amazon.com>
Signed-off-by: Micah Hausler mhausler@amazon.com
What this PR does / why we need it:
Adds support for configurable service account annotations. This will be used for AWS's IAM for Service Accounts (aws/containers-roadmap#23).
Which issue this PR fixes
N/A
Special notes for your reviewer:
This is a non-breaking change that will facilitate IAM for Service Accounts once kubernetes-sigs/external-dns#1172 lands in a release
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
)