Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nats] Fix ValidationError: unknown field "serviceName" #14439

Merged
merged 1 commit into from
Jun 6, 2019
Merged

[stable/nats] Fix ValidationError: unknown field "serviceName" #14439

merged 1 commit into from
Jun 6, 2019

Conversation

guessi
Copy link
Contributor

@guessi guessi commented Jun 4, 2019 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

  • N/A

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @guessi. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guessi
Copy link
Contributor Author

guessi commented Jun 4, 2019

/assign @juan131

juan131
juan131 approved these changes Jun 5, 2019
View reviewed changes
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @guessi

@juan131
Copy link
Collaborator

juan131 commented Jun 5, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2019
@juan131
Copy link
Collaborator

juan131 commented Jun 5, 2019

Hi @guessi

Could you rebase from master and bump the version of the Chart.yaml again? It seems there was a patch release since you created the PR

@guessi
[stable/nats] Fix ValidationError: unknown field "serviceName"
f0de41e 
Signed-off-by: guessi <guessi@gmail.com>
@guessi
Copy link
Contributor Author

guessi commented Jun 5, 2019

@juan131 rebase & fixed

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@juan131
Copy link
Collaborator

juan131 commented Jun 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guessi, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit abb1fde into helm:master Jun 6, 2019
alemorcuq pushed a commit to alemorcuq/charts-1 that referenced this pull request Jun 6, 2019
@guessi @alemorcuq
[stable/nats] Fix ValidationError: unknown field "serviceName" (helm#…
ececb0a 
…14439)

Signed-off-by: guessi <guessi@gmail.com>
@guessi guessi deleted the fix-nats-deployment branch June 6, 2019 15:45
anasinnyk pushed a commit to MacPaw/charts that referenced this pull request Jun 29, 2019
@guessi @anasinnyk
[stable/nats] Fix ValidationError: unknown field "serviceName" (helm#…
4cdf528 
…14439)

Signed-off-by: guessi <guessi@gmail.com>
Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juan131 juan131 juan131 approved these changes

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@juan131 juan131

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guessi @k8s-ci-robot @juan131 @helm-bot