Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] add namespace metadata #14325

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

lwolf
Copy link
Collaborator

@lwolf lwolf commented May 30, 2019

What this PR does / why we need it:

this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553

Signed-off-by: Sergey Nuzhdin ipaq.lw@gmail.com

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 30, 2019
@k8s-ci-robot k8s-ci-robot requested a review from maorfr May 30, 2019 13:27
@k8s-ci-robot
Copy link
Contributor

Hi @lwolf. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2019
@maorfr
Copy link
Member

maorfr commented May 30, 2019

I would love to understand your use case

@lwolf
Copy link
Collaborator Author

lwolf commented May 31, 2019

As I mentioned in the original PR description this change is needed when helm is used purely as templating engine.
Usecase: all charts are rendered individually using helm template --namespace=namespace and added to the VCS, GitOps system applies entire cluster state and keeps it in sync.

Similar issues/usecases/discussions:

@maorfr
Copy link
Member

maorfr commented May 31, 2019

/assign
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lwolf, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit c90d037 into helm:master Jun 1, 2019
rvdh pushed a commit to rvdh/charts that referenced this pull request Jun 3, 2019
this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
@farvour
Copy link

farvour commented Jun 5, 2019

This breaks with helmfile and the dashboards key is being used/defined.

  Error: render error in "grafana/templates/deployment.yaml": template: grafana/templates/deployment.yaml:33:44: executing "grafana/templates/deployment.yaml" at <include (print $.Tem...>: error calling include: template: grafana/templates/dashboards-json-configmap.yaml:9:24: executing "grafana/templates/dashboards-json-configmap.yaml" at <.Release.Namespace>: can't evaluate field Namespace in type interface {}
  Error: plugin "diff" exited with error```

@lwolf
Copy link
Collaborator Author

lwolf commented Jun 5, 2019

this should be fixed in #14425

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants