-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/grafana] add namespace metadata #14325
Conversation
this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace helm/helm#3553 Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
Hi @lwolf. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I would love to understand your use case |
As I mentioned in the original PR description this change is needed when helm is used purely as templating engine. Similar issues/usecases/discussions:
|
/assign |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lwolf, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace helm/helm#3553 Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
This breaks with helmfile and the
|
this should be fixed in #14425 |
What this PR does / why we need it:
this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553
Signed-off-by: Sergey Nuzhdin ipaq.lw@gmail.com
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
)