Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator]: add EnableAdminAPI option #14030

Merged
merged 2 commits into from
May 21, 2019

Conversation

amine7536
Copy link
Contributor

Signed-off-by: Amine Benseddik amine@qonto.eu

What this PR does / why we need it:

Adds the option the enable Prometheus TSDB admin api. (--web.enable-admin-api)

Special notes for your reviewer:

This option exists in prometheus-operator prometheusSpec but not in the chart : https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
https://github.com/coreos/prometheus-operator/blob/master/pkg/prometheus/statefulset.go#L401

Prometheus documentation : https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x ] DCO signed
  • [ x ] Chart Version bumped
  • [ x ] Variables are documented in the README.md
  • [ x ] title of the PR contains starts with chart name e.g. [stable/chart]

Signed-off-by: Amine Benseddik <amine@qonto.eu>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels May 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @amine7536. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2019
Signed-off-by: Amine Benseddik <amine@qonto.eu>
@vsliouniaev
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amine7536, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9fa4db5 into helm:master May 21, 2019
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
Signed-off-by: Amine Benseddik <amine@qonto.eu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants