Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/graylog]: Move updateStrategy to the correct location #14006

Merged
merged 1 commit into from May 20, 2019
Merged

[stable/graylog]: Move updateStrategy to the correct location #14006

merged 1 commit into from May 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 20, 2019

Signed-off-by: Catarina Tavares catarina.tavares@truphone.com

What this PR does / why we need it:

To be able to successfuly run helm install.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Catarina Tavares <catarina.tavares@truphone.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels May 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tru-cstavares. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2019
@ghost
Copy link
Author

ghost commented May 20, 2019

/assign @KongZ

@k8s-ci-robot
Copy link
Contributor

@tru-cstavares: GitHub didn't allow me to assign the following users: kongz.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @KongZ

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidkarlsen
Copy link
Member

/ok-to-test
/assign
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, tru-cstavares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2f74619 into helm:master May 20, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
Signed-off-by: Catarina Tavares <catarina.tavares@truphone.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
Signed-off-by: Catarina Tavares <catarina.tavares@truphone.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/graylog] unknown field "updateStrategy" in io.k8s.api.core.v1.PodSpec
4 participants