Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/fluent-bit] Fix table formatting in Readme.md #13962

Merged
merged 2 commits into from
May 18, 2019

Conversation

sagarjauhari
Copy link
Contributor

@sagarjauhari sagarjauhari commented May 17, 2019

What this PR does / why we need it:

Table formatting broken in Readme

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sagarjauhari. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@edsiper
Copy link
Collaborator

edsiper commented May 17, 2019

Please sign-off the commit (git commit -a -s...)

@sagarjauhari sagarjauhari force-pushed the patch-1 branch 2 times, most recently from 2a19611 to 67cd164 Compare May 17, 2019 19:46
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 17, 2019
Signed-off-by: Sagar Jauhari <sagarjauhari@users.noreply.github.com>
Signed-off-by: Sagar Jauhari <sagarjauhari@users.noreply.github.com>
@edsiper
Copy link
Collaborator

edsiper commented May 18, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2019
@edsiper
Copy link
Collaborator

edsiper commented May 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsiper, sagarjauhari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0a9a6f7 into helm:master May 18, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
* [stable/fluent-bit] Fix table formatting in Readme.md

Signed-off-by: Sagar Jauhari <sagarjauhari@users.noreply.github.com>

* Bumping version

Signed-off-by: Sagar Jauhari <sagarjauhari@users.noreply.github.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
* [stable/fluent-bit] Fix table formatting in Readme.md

Signed-off-by: Sagar Jauhari <sagarjauhari@users.noreply.github.com>

* Bumping version

Signed-off-by: Sagar Jauhari <sagarjauhari@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants