[stable/spinnaker] Move default profile settings from values to the template

[legal90]

What this PR does / why we need it:

Now templates/configmap/additional-profile-configmaps.yaml template has advanced logic with conditions and dict merging, which brings us the following:

1. Move default profile settings from values to the template.

Default values for gate-local.yml profile (introduced in #10771) will be injected automatically if gce or alb ingress controller is used.
So, there will be no need for some users to set halyard.additionalProfileConfigMaps to true to get it working. Also, other users won't have to explicitly unset halyard.additionalProfileConfigMaps.data.gate-local\.yml if they don't use gce or alb ingress.

2. Disable S3 versioning if Minio is used

Minio is the local S3-compatible storage engine, which is enabled in stable/spinnaker by default (as an alternative to AWS S3). However, it doesn't support versioning, which makes the front50 microservice failing to start.
So the versioning should be disabled according to Spinnaker docs:
https://www.spinnaker.io/setup/install/storage/minio/#editing-your-storage-settings

3. Changes in halyard.additionalProfileConfigMaps.data map

• I removed halyard.additionalProfileConfigMaps.create key from values.yaml because now this ConfigMap will always be created and mounted, in order to get the default settings (p.1) available.
• I also changed the expected type of values in halyard.additionalProfileConfigMaps.data map. Now it could be not only a string, but a dict (map[string]interface{}) too, so users can override any of the fields defined by default, for example:

# overrides-values.yml
halyard:
  additionalProfileConfigMaps:
    data:
      front50-local.yml:  # it's a map, no "|-" here
        foo: bar
        spinnaker:
          s3:
            endpoint: OVERRIDEN_VALUE

will lead to this content of the ConfigMap:

apiVersion: v1
kind: ConfigMap
metadata:
  # ...
data:
  front50-local.yml: |
    foo: bar
    spinnaker:
      s3:
        endpoint: OVERRIDEN_VALUE
        versioning: false

Special notes for your reviewer:

Despite all the changes, this PR saves full backward compatibility. If the user has set halyard.additionalProfileConfigMaps.create to true and defined any profiles in halyard.additionalProfileConfigMaps.data, these profiles will be always respected instead of the defaults generated by the template conditions (if they overlap).

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• title of the PR contains starts with chart name e.g. [stable/chart]

[k8s-ci-robot]

Hi @legal90. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dwardu89]

/ok-to-test

[dwardu89]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dwardu89, legal90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/spinnaker/OWNERS [dwardu89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment