Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/jenkins] Properly handle overwrite config for additional configs #13915

Merged
merged 3 commits into from
May 17, 2019
Merged

[stable/jenkins] Properly handle overwrite config for additional configs #13915

merged 3 commits into from
May 17, 2019

Conversation

startnow65
Copy link
Contributor

What this PR does / why we need it:

Additional configs are only copied (overwritten) to Jenkins home when .Values.master.overwriteConfig is false. This PR updates the template to always overwrite additional configs when .Values.master.overwriteConfig is true and only copy the first time when .Values.master.overwriteConfig is false.

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels May 16, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @startnow65. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@startnow65 startnow65 mentioned this pull request May 16, 2019
Merged
4 tasks
torstenwalter
torstenwalter suggested changes May 17, 2019
View reviewed changes
Copy link
Collaborator

@torstenwalter torstenwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good.

stable/jenkins/templates/config.yaml Outdated Show resolved Hide resolved
stable/jenkins/templates/config.yaml Outdated Show resolved Hide resolved
@startnow65
[stable/jenkins] Properly handle overwriteconfig option for additiona…
d695dfc 
…l configs

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>
@startnow65
[stable/jenkins] Bump chart version
b1d3938 
Signed-off-by: Josiah Adenegan <startnow65@gmail.com>
@startnow65
[stable/jenkins] Added indentation
0e7e6e2 
Signed-off-by: Josiah Adenegan <startnow65@gmail.com>
@torstenwalter
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2019
@torstenwalter
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: startnow65, torstenwalter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 18ce9b5 into helm:master May 17, 2019
@startnow65 startnow65 deleted the jenkins-overwrite-config branch May 17, 2019 17:14
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
@startnow65
[stable/jenkins] Properly handle overwrite config for additional conf…
c5c59bc 
…igs (helm#13915)

* [stable/jenkins] Properly handle overwriteconfig option for additional configs

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>

* [stable/jenkins] Bump chart version

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>

* [stable/jenkins] Added indentation

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@startnow65 @eyenx
[stable/jenkins] Properly handle overwrite config for additional conf…
a0f01f9 
…igs (helm#13915)

* [stable/jenkins] Properly handle overwriteconfig option for additional configs

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>

* [stable/jenkins] Bump chart version

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>

* [stable/jenkins] Added indentation

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>
wmcdona89 pushed a commit to wmcdona89/charts that referenced this pull request Aug 30, 2020
@startnow65 @k8s-ci-robot
[stable/jenkins] Properly handle overwrite config for additional conf…
c76325f 
…igs (helm#13915)

* [stable/jenkins] Properly handle overwriteconfig option for additional configs

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>

* [stable/jenkins] Bump chart version

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>

* [stable/jenkins] Added indentation

Signed-off-by: Josiah Adenegan <startnow65@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@torstenwalter torstenwalter torstenwalter requested changes

@lachie83 lachie83 Awaiting requested review from lachie83

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@startnow65 @k8s-ci-robot @torstenwalter @helm-bot