This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/cockroachdb]: Add more OWNERS to cockroachdb chart #13889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
May 15, 2019
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
May 15, 2019
a-robinson
force-pushed
the
cockroach-owners
branch
from
May 15, 2019 22:29
6639591
to
088be97
Compare
helm-bot
added
the
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
label
May 15, 2019
/assign thanks for this! |
These three all have good knowledge of CockroachDB and experience running it in production on Kubernetes. Signed-off-by: Alex Robinson <alexdwanerobinson@gmail.com>
a-robinson
force-pushed
the
cockroach-owners
branch
from
May 16, 2019 21:41
088be97
to
6464f36
Compare
helm-bot
removed
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
May 16, 2019
Whoops, done. |
helm-bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
May 16, 2019
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-robinson, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
amine7536
pushed a commit
to amine7536/charts
that referenced
this pull request
May 21, 2019
These three all have good knowledge of CockroachDB and experience running it in production on Kubernetes. Signed-off-by: Alex Robinson <alexdwanerobinson@gmail.com>
eyenx
pushed a commit
to eyenx/charts
that referenced
this pull request
May 28, 2019
These three all have good knowledge of CockroachDB and experience running it in production on Kubernetes. Signed-off-by: Alex Robinson <alexdwanerobinson@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
lgtm
Indicates that a PR is ready to be merged.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three all have good knowledge of CockroachDB and experience
running it in production on Kubernetes.
What this PR does / why we need it:
Add more OWNERS to cockroachdb chart to address #13867
Which issue this PR fixes
Special notes for your reviewer:
I don't think I have the necessary permissions to add them as collaborators on the repo. Can whoever approves this do so?
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]