Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cockroachdb]: Add more OWNERS to cockroachdb chart #13889

Merged
merged 1 commit into from
May 21, 2019

Conversation

a-robinson
Copy link
Collaborator

These three all have good knowledge of CockroachDB and experience
running it in production on Kubernetes.

What this PR does / why we need it:

Add more OWNERS to cockroachdb chart to address #13867

Which issue this PR fixes

Special notes for your reviewer:

I don't think I have the necessary permissions to add them as collaborators on the repo. Can whoever approves this do so?

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 15, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 15, 2019
@a-robinson
Copy link
Collaborator Author

@maorfr
Copy link
Member

maorfr commented May 16, 2019

/assign

thanks for this!
please add them to the Chart.yaml file as well.

These three all have good knowledge of CockroachDB and experience
running it in production on Kubernetes.

Signed-off-by: Alex Robinson <alexdwanerobinson@gmail.com>
@helm-bot helm-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2019
@a-robinson
Copy link
Collaborator Author

Whoops, done.

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2019
@maorfr
Copy link
Member

maorfr commented May 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-robinson, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e0ca5d1 into helm:master May 21, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
These three all have good knowledge of CockroachDB and experience
running it in production on Kubernetes.

Signed-off-by: Alex Robinson <alexdwanerobinson@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
These three all have good knowledge of CockroachDB and experience
running it in production on Kubernetes.

Signed-off-by: Alex Robinson <alexdwanerobinson@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants