[stable/drone] #13867 Update owners

[zakkg3]

Because of #13867

Here is a previous PR.

There are a few things to improve in this chart that I would like to discuss with @christian-roggia and @cpanato @max-rocket-internet

1- For K8s enabled, the DRONE_RPC_HOST env var is not specified so by default it's = to DRONE_HOST, which means the interaction job <-> server is going through the public endpoint instead to the service, not ideal in some cases. It would be nice to have the option to set it to the local service.

2- Update to drone 1.1.0 instead of the release candidate 1.0.0-rc.5

3- Add the option to install the secret plugin, to be able to read secrets from K8s backend

4- Fix Grpc (not in drone1.0) there is an open pr for this

One more thing: @paulczar is in chart.yaml but not in OWNERS, let me know if I should include him.?

[k8s-ci-robot]

Hi @zakkg3. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maorfr]

/assign @paulczar

can you ptal? :)

[max-rocket-internet]

Hey @zakkg3

1- For K8s enabled, the DRONE_RPC_HOST env var is not sp..

Nice 💯

2- Update to drone 1.1.0 instead of the release candidate 1.0.0-rc.5

Nice 💯

3- Add the option to install the secret plugin, to be able to read secrets from K8s backend

What do you mean here? helm-secrets Helm plugin?

4- Fix Grpc (not in drone1.0) there is an open pr for this

Nice 💯

[zakkg3]

Hey @max-rocket-internet

3- Add the option to install the secret plugin, to be able to read secrets from K8s backend

What do you mean here? helm-secrets Helm plugin?

External secrets are stored in a third party system, such as Vault or the AWS Secrets Manager, and are requested at runtime. In order to use external secrets you must install and configure a secret plugin

[zakkg3]

/assign @maorfr
:)

[christian-roggia]

/approve

I fully approve of this and I really would love to get some help in maintaining this chart.

I am sorry for the late answer but I'm currently extremely busy with the KubeCon.

[maorfr]

/ok-to-test
/lgtm

thanks! welcome @zakkg3 !

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christian-roggia, maorfr, zakkg3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/drone/OWNERS [christian-roggia,maorfr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment