Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/datadog] Support leader election check on daemonset agent #13849

Merged

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented May 15, 2019

What this PR does / why we need it:

Which issue this PR fixes

Add RBAC permission to Daemonset Agent to get "endpoints" API server resources for "leader election check" support.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
@k8s-ci-robot k8s-ci-robot requested a review from hkaj May 15, 2019 09:23
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@clamoriniere clamoriniere changed the title Support leader election check on daemonset agent [stable/datadog] Support leader election check on daemonset agent May 15, 2019
@clamoriniere
Copy link
Collaborator Author

/assign @mfpierre

@k8s-ci-robot
Copy link
Contributor

@clamoriniere: GitHub didn't allow me to assign the following users: mfpierre.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mfpierre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clamoriniere
Copy link
Collaborator Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@clamoriniere: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clamoriniere
Copy link
Collaborator Author

/approve

@CharlyF
Copy link
Collaborator

CharlyF commented May 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlyF, clamoriniere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aa8904b into helm:master May 15, 2019
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants