Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] consider values in nodePorts for LoadBalancer #13735

Merged
merged 1 commit into from
May 17, 2019

Conversation

bhavin192
Copy link
Contributor

What this PR does / why we need it:

  • Makes it possible to specify nodePort values when the controller
    service type is LoadBalancer
  • Update README.md
  • Bump the version

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bhavin192. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 14, 2019
@ChiefAlexander
Copy link
Collaborator

I am not certain that this is valid. Can you point me to the documentation/code that allows you to define the nodeport when using type load-balancer. All I see is https://kubernetes.io/docs/concepts/services-networking/#publishing-services-service-types where it calls it out as being auto created.

NodePort and ClusterIP services, to which the external load balancer will route, are automatically created.

@ChiefAlexander
Copy link
Collaborator

/assign

@bhavin192
Copy link
Contributor Author

From API reference doc,

The port on each node on which this service is exposed when type=NodePort or LoadBalancer. Usually assigned by the system. If specified, it will be allocated to the service if unused or else creation of the service will fail. Default is to auto-allocate a port if the ServiceType of this Service requires one. More info: https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport

https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#serviceport-v1-core

@ChiefAlexander
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2019
@bhavin192
Copy link
Contributor Author

/test pull-charts-e2e

- Makes it possible to specify nodePort values when the controller
  service type is LoadBalancer
- Update README.md
- Bump the version

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
@ChiefAlexander
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bhavin192, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit c3a3cbb into helm:master May 17, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
…elm#13735)

- Makes it possible to specify nodePort values when the controller
  service type is LoadBalancer
- Update README.md
- Bump the version

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
…elm#13735)

- Makes it possible to specify nodePort values when the controller
  service type is LoadBalancer
- Update README.md
- Bump the version

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants