-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/nginx-ingress] consider values in nodePorts for LoadBalancer #13735
Conversation
Hi @bhavin192. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I am not certain that this is valid. Can you point me to the documentation/code that allows you to define the nodeport when using type load-balancer. All I see is https://kubernetes.io/docs/concepts/services-networking/#publishing-services-service-types where it calls it out as being auto created.
|
/assign |
From API reference doc,
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#serviceport-v1-core |
/ok-to-test |
/test pull-charts-e2e |
- Makes it possible to specify nodePort values when the controller service type is LoadBalancer - Update README.md - Bump the version Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
8ef092f
to
3e41979
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bhavin192, ChiefAlexander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…elm#13735) - Makes it possible to specify nodePort values when the controller service type is LoadBalancer - Update README.md - Bump the version Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
…elm#13735) - Makes it possible to specify nodePort values when the controller service type is LoadBalancer - Update README.md - Bump the version Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
What this PR does / why we need it:
nodePort
values when the controllerservice type is
LoadBalancer
README.md
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]