-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/kiam] Add metadata on services #13724
Conversation
Hi @gloutsch. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com>
ef2544e
to
51029b2
Compare
/assign thanks for this! |
Signed-off-by: Maor Friedman <maor.friedman@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gloutsch, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thx mate ! |
* [stable/kiam] Add metadata on services Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com> * prepare to resolve conflict Signed-off-by: Maor Friedman <maor.friedman@redhat.com>
* [stable/kiam] Add metadata on services Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com> * prepare to resolve conflict Signed-off-by: Maor Friedman <maor.friedman@redhat.com>
* [stable/kiam] Add metadata on services Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com> * prepare to resolve conflict Signed-off-by: Maor Friedman <maor.friedman@redhat.com>
What this PR does / why we need it:
add more metadata on kiam services (agent, server) mainly for prometheus scraping
Which issue this PR fixes
none
Special notes for your reviewer:
cc @ewbankkit for review
Checklist
[stable/chart]