Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kiam] Add metadata on services #13724

Merged
merged 3 commits into from
May 16, 2019

Conversation

gloutsch
Copy link
Contributor

@gloutsch gloutsch commented May 13, 2019

What this PR does / why we need it:

add more metadata on kiam services (agent, server) mainly for prometheus scraping

Which issue this PR fixes

none

Special notes for your reviewer:

cc @ewbankkit for review

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @gloutsch. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2019
Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 13, 2019
@maorfr
Copy link
Member

maorfr commented May 16, 2019

/assign
/ok-to-test

thanks for this!

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2019
@maorfr
Copy link
Member

maorfr commented May 16, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gloutsch, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 81e1d29 into helm:master May 16, 2019
@gloutsch
Copy link
Contributor Author

thx mate !

@gloutsch gloutsch deleted the kiam-service-annotations branch May 16, 2019 08:30
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
* [stable/kiam] Add metadata on services

Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com>

* prepare to resolve conflict

Signed-off-by: Maor Friedman <maor.friedman@redhat.com>
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
* [stable/kiam] Add metadata on services

Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com>

* prepare to resolve conflict

Signed-off-by: Maor Friedman <maor.friedman@redhat.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
* [stable/kiam] Add metadata on services

Signed-off-by: Gauthier Loutsch <gauthier.loutsch@contentsquare.com>

* prepare to resolve conflict

Signed-off-by: Maor Friedman <maor.friedman@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants