Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/rabbitmq] Update README #13712

Merged
merged 1 commit into from
May 14, 2019
Merged

[stable/rabbitmq] Update README #13712

merged 1 commit into from
May 14, 2019

Conversation

senk
Copy link
Contributor

@senk senk commented May 13, 2019

Fix some missing apostrophes in rabbitmq README

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @senk. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 13, 2019
@senk
Copy link
Contributor Author

senk commented May 13, 2019

/assign @carrodher

Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @senk

Even if you're just updating the README.md, you'll need to bump the patch version of the chart (Chart.yml) in order to pass the CI tests. Could you please update your PR bumping it?

Fix some missing apostrophes in rabbitmq README

Signed-off-by: Robin Naundorf <r.naundorf@fh-muenster.de>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2019
@juan131
Copy link
Collaborator

juan131 commented May 14, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan131, senk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit dd4551f into helm:master May 14, 2019
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
Fix some missing apostrophes in rabbitmq README

Signed-off-by: Robin Naundorf <r.naundorf@fh-muenster.de>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
Fix some missing apostrophes in rabbitmq README

Signed-off-by: Robin Naundorf <r.naundorf@fh-muenster.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants