Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube-state-metrics]: Fix link to metric docu #13647

Merged
merged 1 commit into from
May 15, 2019
Merged

[stable/kube-state-metrics]: Fix link to metric docu #13647

merged 1 commit into from
May 15, 2019

Conversation

florianrusch
Copy link
Contributor

@florianrusch florianrusch commented May 9, 2019 •
edited
Loading

What this PR does / why we need it:

I've fixed the link to the metric docu in the NOTES.txt of the kube-state-metrics chart

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @florianrusch. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 9, 2019
@florianrusch florianrusch force-pushed the patch-2 branch 2 times, most recently from 9bf1ed4 to 1372b46 Compare May 9, 2019 17:31
@florianrusch florianrusch marked this pull request as ready for review May 9, 2019 17:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2019
@tariq1890
Copy link
Collaborator

@florianrusch Could you rebase this PR?

@tariq1890
Copy link
Collaborator

@davidkarlsen FYI

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 15, 2019
@florianrusch
Copy link
Contributor Author

@tariq1890 done

tariq1890
tariq1890 reviewed May 15, 2019
View reviewed changes
stable/kube-state-metrics/Chart.yaml Outdated
@@ -5,7 +5,7 @@ keywords:
- metric
- monitoring
- prometheus
version: 1.3.0
version: 1.5.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be changed again. Sorry :(.

Suggested change
version: 1.5.1
version: 1.6.1

@tariq1890
Copy link
Collaborator

tariq1890 commented May 15, 2019 •
edited
Loading

@florianrusch Thanks for your patience with this PR. Looks like the following things need to be done.

i) Rebase with master and resolve merge conflicts.
ii) Fix the last review comment
iii) Squash the commits into one. The squash commit also needs to be signed off.

@florianrusch
[stable/kube-state-metrics]: Fix link to metric docu
e1536dd 
Signed-off-by: Florian Rusch <git@florianrusch.de>

[stable/kube-state-metrics] Bump Chart version

Co-Authored-By: Tariq Ibrahim <tariq181290@gmail.com>
Bump Version

Signed-off-by: Florian Rusch <git@florianrusch.de>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 15, 2019
@florianrusch
Copy link
Contributor Author

@tariq1890 Sorry, it's late here in germany. Hope everything is fine now :-)

@tariq1890
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@tariq1890: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tariq1890
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: florianrusch, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@tariq1890
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@tariq1890: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit c0e04ea into helm:master May 15, 2019
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@florianrusch @goshlanguage
[stable/kube-state-metrics]: Fix link to metric docu (helm#13647)
7b56495 
Signed-off-by: Florian Rusch <git@florianrusch.de>

[stable/kube-state-metrics] Bump Chart version

Co-Authored-By: Tariq Ibrahim <tariq181290@gmail.com>
Bump Version

Signed-off-by: Florian Rusch <git@florianrusch.de>
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
@florianrusch
[stable/kube-state-metrics]: Fix link to metric docu (helm#13647)
e4766cb 
Signed-off-by: Florian Rusch <git@florianrusch.de>

[stable/kube-state-metrics] Bump Chart version

Co-Authored-By: Tariq Ibrahim <tariq181290@gmail.com>
Bump Version

Signed-off-by: Florian Rusch <git@florianrusch.de>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@florianrusch @eyenx
[stable/kube-state-metrics]: Fix link to metric docu (helm#13647)
bad99e0 
Signed-off-by: Florian Rusch <git@florianrusch.de>

[stable/kube-state-metrics] Bump Chart version

Co-Authored-By: Tariq Ibrahim <tariq181290@gmail.com>
Bump Version

Signed-off-by: Florian Rusch <git@florianrusch.de>
@florianrusch florianrusch deleted the patch-2 branch June 2, 2019 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tariq1890 tariq1890 tariq1890 left review comments

@jlegrone jlegrone Awaiting requested review from jlegrone

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florianrusch @k8s-ci-robot @tariq1890 @helm-bot