Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/raw] fix: ConfigMap Artifact created for every raw chart #13633

Merged
merged 1 commit into from
May 20, 2019
Merged

[incubator/raw] fix: ConfigMap Artifact created for every raw chart #13633

merged 1 commit into from
May 20, 2019

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented May 9, 2019 •
edited
Loading

What this PR does / why we need it:

This PR changes the default values.yaml to contain no items under templates. It had a dummy item just to pass the charts CI, but after reading the documentation of ct, specifically https://github.com/helm/chart-testing/blob/acfb89768ede45c25fa6fa56ae345d23f68e4f82/doc/ct_install.md, I realized that it isn't needed at all. Instead, I added ci/templates-values.yaml and ci/resources-values.yaml according to the ct convension, so that ct would use those CI-specific values.yaml for testing.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@mumoshu mumoshu force-pushed the incubator-raw-fix-default-values branch from b6df67b to 194cb9d Compare May 9, 2019 04:23
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 9, 2019
@mumoshu mumoshu force-pushed the incubator-raw-fix-default-values branch from 194cb9d to aebca29 Compare May 9, 2019 04:24
@mumoshu mumoshu mentioned this pull request May 9, 2019
Closed
@mumoshu
Copy link
Collaborator Author

mumoshu commented May 9, 2019

Just wondering if I can /lgtm on this myself :)

@mumoshu
Copy link
Collaborator Author

mumoshu commented May 9, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@mumoshu: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ciiqr ciiqr mentioned this pull request May 11, 2019
Merged
3 tasks
@mumoshu mumoshu mentioned this pull request May 13, 2019
Open
@mumoshu mumoshu force-pushed the incubator-raw-fix-default-values branch from aebca29 to 6341a8a Compare May 13, 2019 13:55
@mumoshu
Copy link
Collaborator Author

mumoshu commented May 13, 2019

@josdotso Would you mind reviewing this? Thanks!

@dcwangmit01
Copy link
Contributor

/lgtm

Looks good to me. CI won't know who I am, but the PR looks good. Thanks for fixing this @mumoshu

@k8s-ci-robot
Copy link
Contributor

@dcwangmit01: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Looks good to me. CI won't know who I am, but the PR looks good. Thanks for fixing this @mumoshu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

josdotso
josdotso approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@josdotso josdotso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks!

@josdotso
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2019
@mumoshu mumoshu force-pushed the incubator-raw-fix-default-values branch from 6341a8a to 3c0ada6 Compare May 16, 2019 02:55
@helm-bot helm-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 16, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 16, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2019
@mumoshu
[incubator/raw] fix: ConfigMap Artifact created for every raw chart
e617faa 
Fixes helm#13188

Signed-off-by: Yusuke KUOKA <ykuoka@gmail.com>
@mumoshu mumoshu force-pushed the incubator-raw-fix-default-values branch from 3c0ada6 to e617faa Compare May 16, 2019 02:56
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2019
@mumoshu
Copy link
Collaborator Author

mumoshu commented May 16, 2019

Bumped the chart version again to avoid the merge conflict.

@mumoshu
Copy link
Collaborator Author

mumoshu commented May 16, 2019

@josdotso Would you mind putting /lgtm once again? Thanks!

@josdotso
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcwangmit01, josdotso, mumoshu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 446292d into helm:master May 20, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
@mumoshu
[incubator/raw] fix: ConfigMap Artifact created for every raw chart (h…
18968d1 
…elm#13633)

Fixes helm#13188

Signed-off-by: Yusuke KUOKA <ykuoka@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@mumoshu @eyenx
[incubator/raw] fix: ConfigMap Artifact created for every raw chart (h…
440f622 
…elm#13633)

Fixes helm#13188

Signed-off-by: Yusuke KUOKA <ykuoka@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josdotso josdotso josdotso approved these changes

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[incubator/raw] ConfigMap Artifact created for every raw chart
5 participants
@mumoshu @k8s-ci-robot @dcwangmit01 @josdotso @helm-bot