Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/graylog] Move hard coded parts of graylog.conf to values.yaml #13603

Closed
wants to merge 1 commit into from
Closed

[stable/graylog] Move hard coded parts of graylog.conf to values.yaml #13603

wants to merge 1 commit into from

Conversation

juliohm1978
Copy link
Contributor

Proposed fix for #13602, creates a more flexible ConfigMap for graylog.conf.

This allows pretty much every aspect of graylog.conf to be defined in values.yaml, instead of hard coding most of it in the ConfigMap template.

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juliohm1978
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kongz

If they are not already assigned, you can assign the PR to them by writing /assign @kongz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @juliohm1978. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Moves all fixed values from the graylog.conf ConfigMap template to va…
cf34593 
…lues.yaml, allowing customization of all other values that are not derived from release metadata.

Signed-off-by: juliohm1978 <jhm@juliohm.com.br>

Remove trailing whitespaces from values.yaml

Signed-off-by: juliohm1978 <jhm@juliohm.com.br>
@juliohm1978 juliohm1978 changed the title Move hard coded parts of graylog.conf to values.yaml [stable/graylog] Move hard coded parts of graylog.conf to values.yaml May 8, 2019
@juliohm1978
Copy link
Contributor Author

This should be superseeded by #12983, which allows additional content to be appened to graylog.conf using new entries in values.yaml.

Thank you for support.
Best regards.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sameersbn sameersbn Awaiting requested review from sameersbn

Assignees
No one assigned
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliohm1978 @k8s-ci-robot @helm-bot