-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/nginx-ingress] Document full key for external-dns example #13564
[stable/nginx-ingress] Document full key for external-dns example #13564
Conversation
Hi @AndiDog. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign Thanks for updating the docs! |
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
9362b8b
to
2106aac
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndiDog, ChiefAlexander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…lm#13564) Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
…lm#13564) Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
What this PR does / why we need it:
Completes the external-dns example using the full nested key, so it could be copy-pasted without wondering where the
annotations
key must go.Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
@jackzampolin @mgoodness