Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Document full key for external-dns example #13564

Merged
merged 1 commit into from
May 20, 2019

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented May 7, 2019

What this PR does / why we need it:

Completes the external-dns example using the full nested key, so it could be copy-pasted without wondering where the annotations key must go.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • title of the PR contains starts with chart name e.g. [stable/chart]

@jackzampolin @mgoodness

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 7, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @AndiDog. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChiefAlexander
Copy link
Collaborator

/assign
/ok-to-test

Thanks for updating the docs!

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2019
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
@AndiDog AndiDog force-pushed the nginx-ingress-external-dns-readme branch from 9362b8b to 2106aac Compare May 19, 2019 17:21
@AndiDog
Copy link
Contributor Author

AndiDog commented May 19, 2019

/retest

@ChiefAlexander
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndiDog, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 29d635c into helm:master May 20, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
…lm#13564)

Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
…lm#13564)

Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants