Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/home-assistant] support for optional VS Code server sidecar #13538

Merged
merged 4 commits into from
May 15, 2019

Conversation

billimek
Copy link
Collaborator

@billimek billimek commented May 6, 2019

What this PR does / why we need it:

Adds support for an optional sidecar container running VS Code Server for editing home-assistant configuration files

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 6, 2019
@billimek
Copy link
Collaborator Author

billimek commented May 6, 2019

This is what it looks like in practice, with the home-assistant VS Code extension installed:

image

@billimek
Copy link
Collaborator Author

billimek commented May 6, 2019

/assign @unguiculus

Signed-off-by: Jeff Billimek <jeff@billimek.com>
Signed-off-by: Jeff Billimek <jeff@billimek.com>
Signed-off-by: Jeff Billimek <jeff@billimek.com>
Signed-off-by: Jeff Billimek <jeff@billimek.com>
@maorfr
Copy link
Member

maorfr commented May 15, 2019

hey @billimek,

think you can 'recruit' someone to work on this chart with you? :)
that way you can pair and approve each other's changes without waiting for global maintainers...

@billimek
Copy link
Collaborator Author

hey @billimek,

think you can 'recruit' someone to work on this chart with you? :)
that way you can pair and approve each other's changes without waiting for global maintainers...

Hi @maorfr, yes I would love to! It was my hope that I could recruit one or two people who have submitted their own PRs for this chart (this is what I did for stable/unifi), but none have really materialized as yet. I've also reached-out to the Home Assistant development community to find a volunteer but no takers yet :(

@maorfr
Copy link
Member

maorfr commented May 15, 2019

/assign
/lgtm

would you make another attempt to recruit? :)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 492f622 into helm:master May 15, 2019
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
…elm#13538)

* support for optional VS Code server sidecar

Signed-off-by: Jeff Billimek <jeff@billimek.com>

* remove use of init container

Signed-off-by: Jeff Billimek <jeff@billimek.com>

* expanding readme and making vscode dir configurable

Signed-off-by: Jeff Billimek <jeff@billimek.com>

* fix conflicintg port names and make password env value a secret

Signed-off-by: Jeff Billimek <jeff@billimek.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
…elm#13538)

* support for optional VS Code server sidecar

Signed-off-by: Jeff Billimek <jeff@billimek.com>

* remove use of init container

Signed-off-by: Jeff Billimek <jeff@billimek.com>

* expanding readme and making vscode dir configurable

Signed-off-by: Jeff Billimek <jeff@billimek.com>

* fix conflicintg port names and make password env value a secret

Signed-off-by: Jeff Billimek <jeff@billimek.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants