[stable/opa] add namespace selector to OPA webhook resource and bump …

[cplee]

…version

Signed-off-by: Casey Lee cplee@nektos.com

What this PR does / why we need it:

@tsandall
When allowing the helm chart to manage the self-signed certs, it causes certs to be recreated on an upgrade and then the webhook restricts the opa chart for upgrading itself...resulting in deadlock.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• title of the PR contains starts with chart name e.g. [stable/chart]

[k8s-ci-robot]

Hi @cplee. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tsandall]

@cplee I've got some questions/comments about this change. Let me know what you think!

[cplee]

@tsandall thanks for the feedback! please check this latest commit.

[tsandall]

@cplee this change looks OK in isolation however what I'm not sure about is how to ensure that it works as expected. I.e., users will have to make sure they label the namespace where OPA is deployed accordingly. Is there any precedent for this? Are there other cases where self-management becomes a problem?

[cplee]

@tsandall I've been having some headaches with the OPA helm chart in which an update is creating a new cert that is out of sync with the cert the pod for OPA is using. This causes the webhook to fail for the other resources in the OPA helm chart...triggering a rollback. The rollback doesn't rollback cleanly since the webhook is now unable to run with inconsistent certs. At his point, the only workaround is to change the FailPolicy to Ignore.

[tsandall]

@cplee understood. I finally had time to test this out manually. I think since it's opt-out it's fine to have it on by default. We can recommend people label sensitive namespaces accordingly.

[tsandall]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cplee, tsandall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/opa/OWNERS [tsandall]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tsandall]

/ok-to-test

[k8s-ci-robot]

@tsandall: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.