Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nats] Update configuration path for gnatsd.conf #13505

Merged
merged 1 commit into from
May 6, 2019
Merged

[stable/nats] Update configuration path for gnatsd.conf #13505

merged 1 commit into from
May 6, 2019

Conversation

guessi
Copy link
Contributor

@guessi guessi commented May 3, 2019 •
edited
Loading

What this PR does / why we need it:

Don't hard-code bitnami in any configuration file or path, except for the Docker image repo.

Which issue this PR fixes

  • N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@guessi
[stable/nats] Update configuration path for gnatsd.conf
b724860 
Signed-off-by: guessi <guessi@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @guessi. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 3, 2019
@guessi
Copy link
Contributor Author

guessi commented May 3, 2019

/assign @prydonius

tompizmor
tompizmor approved these changes May 6, 2019
View reviewed changes
Copy link
Collaborator

@tompizmor tompizmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guessi, tompizmor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5d1537d into helm:master May 6, 2019
@guessi guessi deleted the update-nats branch May 7, 2019 01:58
@guessi guessi mentioned this pull request May 7, 2019
Merged
4 tasks
dpkirchner pushed a commit to dpkirchner/charts that referenced this pull request May 9, 2019
@guessi @dpkirchner
[stable/nats] Update configuration path for gnatsd.conf (helm#13505)
70a2a35 
Signed-off-by: guessi <guessi@gmail.com>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@guessi @goshlanguage
[stable/nats] Update configuration path for gnatsd.conf (helm#13505)
5bfa44e 
Signed-off-by: guessi <guessi@gmail.com>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@guessi @goshlanguage
[stable/nats] support for deploying nats with "Deployment" (helm#13537)
7b3b736 
* [stable/nats] support deploying nats with "Deployment"

Signed-off-by: guessi <guessi@gmail.com>

* [stable/nats] split statefulset/deployment with "mode" flag

Signed-off-by: guessi <guessi@gmail.com>

* [stable/nats] fix missing params in values-production.yaml

Signed-off-by: guessi <guessi@gmail.com>

* [stable/nats] enhanced resource type detection

Signed-off-by: guessi <guessi@gmail.com>

* Revert "[stable/nats] Update configuration path for gnatsd.conf (helm#13505)"

This reverts commit 5d1537d.

See discussion at the following link:
- helm#13537 (comment)

Signed-off-by: guessi <guessi@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@guessi @eyenx
[stable/nats] Update configuration path for gnatsd.conf (helm#13505)
cc1b64c 
Signed-off-by: guessi <guessi@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@guessi @eyenx
[stable/nats] support for deploying nats with "Deployment" (helm#13537)
61c08ec 
* [stable/nats] support deploying nats with "Deployment"

Signed-off-by: guessi <guessi@gmail.com>

* [stable/nats] split statefulset/deployment with "mode" flag

Signed-off-by: guessi <guessi@gmail.com>

* [stable/nats] fix missing params in values-production.yaml

Signed-off-by: guessi <guessi@gmail.com>

* [stable/nats] enhanced resource type detection

Signed-off-by: guessi <guessi@gmail.com>

* Revert "[stable/nats] Update configuration path for gnatsd.conf (helm#13505)"

This reverts commit 5d1537d.

See discussion at the following link:
- helm#13537 (comment)

Signed-off-by: guessi <guessi@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tompizmor tompizmor tompizmor approved these changes

@juan131 juan131 Awaiting requested review from juan131

@sameersbn sameersbn Awaiting requested review from sameersbn

Assignees

@prydonius prydonius

@maorfr maorfr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guessi @k8s-ci-robot @tompizmor @prydonius @maorfr @helm-bot