Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kong] introduce support for dbless Ingress Controller #13475

Merged
merged 1 commit into from
May 13, 2019
Merged

[stable/kong] introduce support for dbless Ingress Controller #13475

merged 1 commit into from
May 13, 2019

Conversation

hbagdi
Copy link
Collaborator

@hbagdi hbagdi commented May 2, 2019

Signed-off-by: Harry Bagdi harrybagdi@gmail.com

What this PR does / why we need it:

  • introduces support to deploy Kong as an Ingress Controller without a database

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 2, 2019
@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 2, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@hbagdi
Copy link
Collaborator Author

hbagdi commented May 2, 2019

/assign @shashiranjan84

@hbagdi
Copy link
Collaborator Author

hbagdi commented May 2, 2019

/test pull-charts-e2e

@hbagdi
Copy link
Collaborator Author

hbagdi commented May 2, 2019

The CI failed but doesn't even have any logs.

@unguiculus Any clue?

@hbagdi
Copy link
Collaborator Author

hbagdi commented May 2, 2019

ping @davidkarlsen as well

@hbagdi hbagdi mentioned this pull request May 3, 2019
Closed
@hbagdi
Copy link
Collaborator Author

hbagdi commented May 3, 2019

In an attempt to get logs for the failure, I'll rerun the test.
/test pull-charts-e2e

@hbagdi
Copy link
Collaborator Author

hbagdi commented May 6, 2019

ping @scottrigby for any insight.

@hbagdi hbagdi mentioned this pull request May 8, 2019
Closed
@hbagdi hbagdi force-pushed the kong/dbless branch 2 times, most recently from 965e5cc to 0bf7d20 Compare May 9, 2019 20:23
@hbagdi hbagdi mentioned this pull request May 9, 2019
Closed
4 tasks
shashiranjan84
shashiranjan84 reviewed May 10, 2019
View reviewed changes
stable/kong/README.md Outdated Show resolved Hide resolved
stable/kong/README.md Outdated Show resolved Hide resolved
stable/kong/requirements.lock
@@ -1,9 +1,9 @@
dependencies:
- name: postgresql
repository: https://kubernetes-charts.storage.googleapis.com/
version: 3.18.3
version: 3.9.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not matching with https://github.com/helm/charts/pull/13475/files#diff-509c05d7eb2ab1aaa0709017c4b59a61R3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine since we are pinning 3.9 and any patch version bumps are acceptable.

@hbagdi
[stable/kong] introduce support for dbless Ingress Controller
fd1eb1a 
Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
shashiranjan84
shashiranjan84 approved these changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@shashiranjan84 shashiranjan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi, shashiranjan84

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0350b79 into helm:master May 13, 2019
@hbagdi hbagdi mentioned this pull request May 13, 2019
Merged
@hbagdi hbagdi deleted the kong/dbless branch May 13, 2019 17:58
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@hbagdi @goshlanguage
[stable/kong] introduce support for dbless Ingress Controller (helm#1…
f69efb0 
…3475)

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@hbagdi @eyenx
[stable/kong] introduce support for dbless Ingress Controller (helm#1…
eaeafd9 
…3475)

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shashiranjan84 shashiranjan84 shashiranjan84 approved these changes

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

Assignees

@shashiranjan84 shashiranjan84

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hbagdi @k8s-ci-robot @shashiranjan84 @helm-bot