Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[Stable/apm-server] Support apm-server 7.0.0 #13269

Merged
merged 1 commit into from
May 13, 2019
Merged

[Stable/apm-server] Support apm-server 7.0.0 #13269

merged 1 commit into from
May 13, 2019

Conversation

Mokto
Copy link
Contributor

@Mokto Mokto commented Apr 25, 2019

Signed-off-by: Théo Mathieu tmathieu.github@fastmail.com

What this PR does / why we need it:

This PR make apm-server support version 7.0.0. The healthcheck was working in 6.x.x but it is not working in 7.x.x anymore.

See https://www.elastic.co/guide/en/apm/server/current/high-availability.html for reference.

Which issue this PR fixes

Supports 7.0.0

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Mokto. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Theo Mathieu <tmathieu.github@fastmail.com>
@mumoshu
Copy link
Collaborator

mumoshu commented May 2, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2019
@Mokto
Copy link
Contributor Author

Mokto commented May 13, 2019

Any update on this ? Thanks.

@mumoshu
Copy link
Collaborator

mumoshu commented May 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mokto, mumoshu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3f49472 into helm:master May 13, 2019
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
Signed-off-by: Theo Mathieu <tmathieu.github@fastmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
Signed-off-by: Theo Mathieu <tmathieu.github@fastmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants