Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/logstash] add extraEnv #12810

Merged
merged 2 commits into from
May 13, 2019
Merged

[stable/logstash] add extraEnv #12810

merged 2 commits into from
May 13, 2019

Conversation

kimxogus
Copy link
Contributor

@kimxogus kimxogus commented Apr 4, 2019

Signed-off-by: Taehyun Kim kgyoo8232@gmail.com

What this PR does / why we need it:

This pr adds extra environment variables.
can be used like

extraEnv:
- name: LS_JAVA_OPTS
  value: |
    -Xms512m -Xmx512m -XX:ParallelGCThreads=1

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kimxogus. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kimxogus
Copy link
Contributor Author

kimxogus commented Apr 4, 2019

/assign @christian-roggia

@kimxogus
Copy link
Contributor Author

/assign @rendhalver

@kimxogus
Copy link
Contributor Author

can someone review?

@kimxogus
add extra-env
6750593 
Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
@christian-roggia
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2019
@christian-roggia
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christian-roggia, kimxogus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 112a8c9 into helm:master May 13, 2019
@kimxogus kimxogus deleted the stable/logstash/extra-env branch May 13, 2019 10:58
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@kimxogus @goshlanguage
add extra-env (helm#12810)
b217c89 
Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@kimxogus @eyenx
add extra-env (helm#12810)
97880fa 
Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
@marc-sensenich marc-sensenich mentioned this pull request Jul 17, 2019
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christian-roggia christian-roggia Awaiting requested review from christian-roggia

@rendhalver rendhalver Awaiting requested review from rendhalver

Assignees

@rendhalver rendhalver

@christian-roggia christian-roggia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kimxogus @k8s-ci-robot @christian-roggia @rendhalver @helm-bot