Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

docs(README.md): add link to docs for nginx configMap ☺️ #11993

Merged
merged 1 commit into from
May 17, 2019
Merged

docs(README.md): add link to docs for nginx configMap ☺️ #11993

merged 1 commit into from
May 17, 2019

Conversation

0verc1ocker
Copy link
Contributor

I need this for my future self. It is better than searching the web everytime to find all the configMap values that can be set for the nginx-ingress controller configMap. :)

What this PR does / why we need it:

Just adding a link to configMap for nginx-ingress so it is easier to find the values for the nginx-ingress controller configMap.

Which issue this PR fixes

This is just README docs improvement.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @0verc1ocker. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 7, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2019
@0verc1ocker
Copy link
Contributor Author

Why does nginx-ingress chart need a version bump? I only updated the README. 😢

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Mar 7, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2019
@stale
Copy link

stale bot commented Apr 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 6, 2019
@0verc1ocker
Copy link
Contributor Author

@mgoodness Can we look into merging this link update?

@stale
Copy link

stale bot commented May 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2019
@0verc1ocker
Copy link
Contributor Author

@mgoodness Can we look into merging this link update?

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2019
@ChiefAlexander
Copy link
Collaborator

/assign
/ok-to-test

You are going to have to bump the version before we can merge 😆

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2019
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 17, 2019
@0verc1ocker 0verc1ocker force-pushed the master branch 2 times, most recently from ee30b40 to 2e73264 Compare May 17, 2019 17:53
@0verc1ocker
fix(version): version bump on nginx-ingress chart and resolve conflict
0746ad6 
Signed-off-by: 0verc1ocker <anton.ouzounov@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 17, 2019
@0verc1ocker
Copy link
Contributor Author

0verc1ocker commented May 17, 2019 •
edited
Loading

@ChiefAlexander Hi, can you try now? I bumped up the nignx-ingress chart version and rebased from master. Thanks! 👍

@ChiefAlexander
Copy link
Collaborator

/lgtm

Thanks for the PR!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0verc1ocker, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit d0c98b2 into helm:master May 17, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
@0verc1ocker
fix(version): version bump on nginx-ingress chart and resolve conflict (
86e40eb 
helm#11993)

Signed-off-by: 0verc1ocker <anton.ouzounov@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@0verc1ocker @eyenx
fix(version): version bump on nginx-ingress chart and resolve conflict (
974f212 
helm#11993)

Signed-off-by: 0verc1ocker <anton.ouzounov@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgoodness mgoodness Awaiting requested review from mgoodness

Assignees

@ChiefAlexander ChiefAlexander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0verc1ocker @k8s-ci-robot @ChiefAlexander @helm-bot