Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Commit

Permalink
Update metrics-server chart to show up in kubectl cluster-info
Browse files Browse the repository at this point in the history
Signed-off-by: ryanhartje <ryan.hartje@microsoft.com>
Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

fixed formatting

Signed-off-by: ryanhartje <ryan.hartje@microsoft.com>
Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

forgot to sign off.

Signed-off-by: ryanhartje <ryan.hartje@microsoft.com>
Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

bump version and append values table in README.md

Signed-off-by: ryanhartje <ryan.hartje@microsoft.com>
Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

Update stable/metrics-server/README.md

Co-Authored-By: Tariq Ibrahim <tariq181290@gmail.com>
Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

Update stable/metrics-server/values.yaml

Co-Authored-By: Tariq Ibrahim <tariq181290@gmail.com>
Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

implementing feedback for metrics-server chart. Bumped chart version, updated metric-server-service template with server.labels value

Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

adding new line at EOF for values in metrics-server chart to pass lint

Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

can't win with these autoformatted spaces at the end of my values file...

Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

[stable/metrics-server] Fix readme typo

Signed-off-by: Ryan Hartje <ryan.hartje@microsoft.com>

[stable/metrics-server] updating service variable formatting to be consistent

Signed-off-by: Ryan Hartje <ryan@ryanhartje.com>
  • Loading branch information
goshlanguage committed May 18, 2019
1 parent c3a3cbb commit 3e45224
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 9 deletions.
2 changes: 1 addition & 1 deletion stable/metrics-server/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 0.3.2
description: Metrics Server is a cluster-wide aggregator of resource usage data.
name: metrics-server
version: 2.7.1
version: 2.8.0
keywords:
- metrics-server
home: https://github.com/kubernetes-incubator/metrics-server
Expand Down
7 changes: 4 additions & 3 deletions stable/metrics-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ Parameter | Description | Default
`podAnnotations` | Annotations to be added to pods | `{}`
`priorityClassName` | Pod priority class | `""`
`readinessProbe` | Container readiness probe | See values.yaml
`service.annotations` | Annotations to add to the service | `{}`
`service.port` | Service port to expose | `443`
`service.type` | Type of service to create | `ClusterIP`
`service.Annotations` | Annotations to add to the service | `{}`
`service.Labels` | Labels to be added to the metrics-server service | `{}`
`service.Port` | Service port to expose | `443`
`service.Type` | Type of service to create | `ClusterIP`
`podDisruptionBudget.enabled` | Create a PodDisruptionBudget | `false`
`podDisruptionBudget.minAvailable` | Minimum available instances; ignored if there is no PodDisruptionBudget |
`podDisruptionBudget.maxUnavailable` | Maximum unavailable instances; ignored if there is no PodDisruptionBudget |
9 changes: 6 additions & 3 deletions stable/metrics-server/templates/metric-server-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,18 @@ metadata:
chart: {{ template "metrics-server.chart" . }}
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
{{- with .Values.service.Labels }}
{{ toYaml . | indent 4}}
{{- end }}
annotations:
{{- toYaml .Values.service.annotations | nindent 4 }}
{{- toYaml .Values.service.Annotations | nindent 4 }}
spec:
ports:
- port: {{ .Values.service.port }}
- port: {{ .Values.service.Port }}
protocol: TCP
targetPort: https
selector:
app: {{ template "metrics-server.name" . }}
release: {{ .Release.Name }}
type: {{ .Values.service.type }}
type: {{ .Values.service.Type }}

9 changes: 7 additions & 2 deletions stable/metrics-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,10 @@ affinity: {}
replicas: 1

podAnnotations: {}
# The following annotations guarantee scheduling for critical add-on pods.
# See more at: https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
# scheduler.alpha.kubernetes.io/critical-pod: ''

# priorityClassName: system-node-critical
# priorityClassName: system-node-critical

extraVolumeMounts: []
# - name: secrets
Expand Down Expand Up @@ -88,6 +89,10 @@ securityContext:

service:
annotations: {}
labels: {}
# Add these labels to have metrics-server show up in `kubectl cluster-info`
# kubernetes.io/cluster-service: "true"
# kubernetes.io/name: metrics-server
port: 443
type: ClusterIP

Expand Down

0 comments on commit 3e45224

Please sign in to comment.