-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test chart upgrades #103
Test chart upgrades #103
Conversation
c9273e7
to
c0a0da5
Compare
64765e5
to
58a66b0
Compare
aa60f0f
to
ca2cc9e
Compare
c5ae478
to
35c8aad
Compare
35c8aad
to
1781e91
Compare
@unguiculus I'd appreciate a first pass when you have a chance! |
Thanks. Please give me some time to review and test this. From quickly skimming over it: Have you thought about installing the previous version from the repo instead of checking out the merge base? Doing so, you assume the merge base reflects the previous release. This doesn't necessarily have to be the case. |
I did consider pulling the previous published revision, but I think there are a couple problems with that:
|
Signed-off-by: Jacob LeGrone <git@jacob.work>
Signed-off-by: Jacob LeGrone <git@jacob.work>
f95a5bc
to
6107025
Compare
Signed-off-by: Jacob LeGrone <git@jacob.work>
…eature/upgrade-testing
Co-Authored-By: jlegrone <jlegrone@users.noreply.github.com> Signed-off-by: Jacob LeGrone <git@jacob.work>
2c924b1
to
4040e6d
Compare
Signed-off-by: Jacob LeGrone <git@jacob.work>
99dd0b7
to
841c540
Compare
LGTM but @scottrigby should also approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlegrone @unguiculus I buried my comment in a resolved thread #103 (comment) - this looks good to me 👍
What this PR does / why we need it:
This PR enables testing in-place upgrades of charts that have non-breaking changes according to the semver spec.
The desired behavior of this PR and further discussion can be found here: #25 (comment)
Which issue this PR fixes
closes #25
closes #19
closes #99
closes #100
Special notes for your reviewer:
Some TODOs:
Change the(out of scope for this PR)Git
interface to a "SCM" interface to avoid further tight coupling with git?Known caveats:
helm dependency build
may fail or not produce the same result as the previous revisionRun integration tests with(see #120)go test -cover -tags=integration ./...