Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use provided GITHUB_TOKEN instead of custom PAT #26

Merged
merged 6 commits into from
Aug 9, 2020
Merged

Use provided GITHUB_TOKEN instead of custom PAT #26

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1a55c4
Use GITHUB_TOKEN for release
stuartpb May 23, 2020
f2d401e
Remove section about CR_TOKEN from README
stuartpb May 23, 2020
0217335
Merge branch 'master' into patch-1
scottrigby Aug 8, 2020
27278a1
Use GITHUB_TOKEN in example
unguiculus Aug 9, 2020
5cc8474
Revert token usage
unguiculus Aug 9, 2020
1937dcc
Add back token check
unguiculus Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ A GitHub action to turn a GitHub project into a self-hosted Helm chart repo, usi

1. A GitHub repo containing a directory with your Helm charts (eg: `/charts`)
1. A GitHub branch called `gh-pages` to store the published charts. See `charts_repo_url` for alternatives
1. A GitHub project [Secret](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets#creating-encrypted-secrets) named `CR_TOKEN` with the value of a GitHub [personal access token](https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line#creating-a-token)
* The token must have `repo` scope
* The token's user must have write access to the project
* To mitigate risk you may wish to limit the token to a single project by creating a [machine user](https://developer.github.com/v3/guides/managing-deploy-keys/#machine-users)
* Please note the personal access token is required because of an [Actions bug](https://github.community/t5/GitHub-Actions/Github-action-not-triggering-gh-pages-upon-push/m-p/31266/highlight/true#M743), and will hopefully be unnecessary in the future
1. Create a workflow `.yml` file in your `.github/workflows` directory. An [example workflow](#example-workflow) is available below.
For more information, reference the GitHub Help Documentation for [Creating a workflow file](https://help.github.com/en/articles/configuring-a-workflow#creating-a-workflow-file)

Expand Down Expand Up @@ -51,7 +46,7 @@ jobs:
- name: Run chart-releaser
uses: helm/chart-releaser-action@v1.0.0-rc.1
env:
CR_TOKEN: "${{ secrets.CR_TOKEN }}"
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
davidkarlsen marked this conversation as resolved.
Show resolved Hide resolved
```

This uses [@helm/chart-releaser-action](https://www.github.com/helm/chart-releaser-action) to turn your GitHub project into a self-hosted Helm chart repo.
Expand Down