Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_… #12

Merged
merged 1 commit into from
Feb 11, 2019
Merged

BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_… #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/amp-smartlinks.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ <h1>Hello from Narrativ</h1>
link-selector="a">
</amp-smartlinks>


<div class="linkmate-eligible-links">
<a href="https://www.exampleretailer.com/prod1234">Example Retailer</a>
<a href="https://www.exampleretailer.com/prod1234">Duplicate Example Retailer</a>
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-smartlinks/0.1/amp-smartlinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class AmpSmartlinks extends AMP.BaseElement {
builder.setExtraUrlParams(payload);
const reporter = builder.build();

reporter.trigger('page-impression', dict());
reporter.trigger('page-impression');
}

/**
Expand Down
6 changes: 3 additions & 3 deletions extensions/amp-smartlinks/0.1/linkmate-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function getConfigOptions(element) {
/**
* The slug used to distinguish Narrativ accounts.
* @param {!Element} element
* @return {?string}
* @return {string}
*/
function getNrtvAccountName_(element) {
const nrtvSlug = element.getAttribute('nrtv-account-name');
Expand Down Expand Up @@ -71,7 +71,7 @@ function getExclusiveLinksFlag_(element) {
/**
* What attribute the outbound link variable is stored in an anchor.
* @param {!Element} element
* @return {?string}
* @return {string}
*/
function getLinkAttribute_(element) {
const linkAttribute = element.getAttribute('link-attribute');
Expand All @@ -82,7 +82,7 @@ function getLinkAttribute_(element) {
/**
* Selector used to get all links that are meant to be monetized.
* @param {!Element} element
* @return {?string}
* @return {string}
*/
function getLinkSelector_(element) {
const linkSelector = element.getAttribute('link-selector');
Expand Down