BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_…

…impression request (#12)
hellonarrativ · Feb 11, 2019 · 53f4eb6 · 53f4eb6
1 parent 80f955a
commit 53f4eb6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/examples/amp-smartlinks.html b/examples/amp-smartlinks.html
@@ -37,7 +37,6 @@ <h1>Hello from Narrativ</h1>
       link-selector="a">
   </amp-smartlinks>
 
-
   <div class="linkmate-eligible-links">
     <a href="https://www.exampleretailer.com/prod1234">Example Retailer</a>
     <a href="https://www.exampleretailer.com/prod1234">Duplicate Example Retailer</a>

diff --git a/extensions/amp-smartlinks/0.1/amp-smartlinks.js b/extensions/amp-smartlinks/0.1/amp-smartlinks.js
@@ -153,7 +153,7 @@ export class AmpSmartlinks extends AMP.BaseElement {
     builder.setExtraUrlParams(payload);
     const reporter = builder.build();
 
-    reporter.trigger('page-impression', dict());
+    reporter.trigger('page-impression');
   }
 
   /**

diff --git a/extensions/amp-smartlinks/0.1/linkmate-options.js b/extensions/amp-smartlinks/0.1/linkmate-options.js
@@ -34,7 +34,7 @@ export function getConfigOptions(element) {
 /**
  * The slug used to distinguish Narrativ accounts.
  * @param {!Element} element
- * @return {?string}
+ * @return {string}
  */
 function getNrtvAccountName_(element) {
   const nrtvSlug = element.getAttribute('nrtv-account-name');
@@ -71,7 +71,7 @@ function getExclusiveLinksFlag_(element) {
 /**
  * What attribute the outbound link variable is stored in an anchor.
  * @param {!Element} element
- * @return {?string}
+ * @return {string}
  */
 function getLinkAttribute_(element) {
   const linkAttribute = element.getAttribute('link-attribute');
@@ -82,7 +82,7 @@ function getLinkAttribute_(element) {
 /**
  * Selector used to get all links that are meant to be monetized.
  * @param {!Element} element
- * @return {?string}
+ * @return {string}
  */
 function getLinkSelector_(element) {
   const linkSelector = element.getAttribute('link-selector');