vdev_id: add comments for PR openzfs#16603 feedback

Signed-off-by: Matthew Heller <matthew.f.heller@accre.vanderbilt.edu>
hellermf · Oct 8, 2024 · 22f5bb6 · 22f5bb6
1 parent 5bf3a6b
commit 22f5bb6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/man/man5/vdev_id.conf.5 b/man/man5/vdev_id.conf.5
@@ -95,7 +95,7 @@ and a default mapping applied to the others.
 .It Sy zpad_slot Ar digits
 Pad slot numbers with zeros to make them
 .Ar digits
-long.
+long, which can help to make disk names a consistent length and easier to sort.
 .
 .It Sy multipath Sy yes Ns | Ns Sy no
 Specifies whether

diff --git a/udev/vdev_id b/udev/vdev_id
@@ -432,6 +432,9 @@ sas_handler() {
 		SLOT=$(echo "$d" | sed -e 's/^.*://')
 		;;
 	"bay_lun")
+		# Like 'bay' but with the LUN number appened. Added for SAS 
+		# multi-actuator HDDs, where one physical drive has multiple
+		# LUNs, thus multiple logical drives share the same bay number
 		i=$((i + 2))
 		d=$(eval echo '$'{$i})
 		LUN="-lun$(echo "$d" | sed -e 's/^.*://')"