Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only remove primary index when search next without extend #948

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

cossonleo
Copy link
Contributor

Only remove primary selection with search_next without extend.
hx_s2

@archseer
Copy link
Member

archseer commented Nov 1, 2021

search_next should maybe find the next match after each selection? https://asciinema.org/a/4IhQw1mLbyMbSBmwQbcTtHHlG

Here I select t then search for u.

We can change the code so it does selection.transform(|range| search_impl(range...)

@EpocSquadron
Copy link
Contributor

@archseer that functionality feels a bit orthogonal to this. I'd argue for a separate issue to track that and get this feature merged sooner.

@archseer archseer merged commit 1720b98 into helix-editor:master Nov 2, 2021
@archseer
Copy link
Member

archseer commented Nov 2, 2021

By the way @cossonleo I see that you're using the solarized theme, could you contribute it to runtime/themes?

@cossonleo
Copy link
Contributor Author

By the way @cossonleo I see that you're using the solarized theme, could you contribute it to runtime/themes?

I‘ll commit a PR when it is updated to newest highlight tag

@cossonleo cossonleo deleted the search_next branch November 2, 2021 13:31
archseer pushed a commit that referenced this pull request Nov 6, 2021
* Add reverse search functionality

* Change keybindings for extend to be in select mode, incorporate Movement and Direction enums

* Fix accidental revert of #948 in rebase

* Add reverse search to docs, clean up mismatched whitespace

* Reverse search optimization

* More optimization via github feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants