fix windows builds #6845
Merged
fix windows builds #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
E-easy
pascalkuthe
commented
Apr 21, 2023
Comment on lines
-440
to
+441
| if cfg!(all(windows, target_env = "msvc")) { | ||
| if compiler.is_like_msvc() { |
There was a problem hiding this comment.
this is unrelated but allows us to cross-compile helix (otherwise it uses the host environment here as that is the tsrgrt of the build script) and that didn't seem worth its own pr
|
@pascalkuthe This fix does work for me, it builds with no errors. Thanks for looking into it! |
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6844
CI doesn't seem super reliable because the caching strategy around grammars is a bit dodgy, so I fiddled around and after a while, I got
cargo-xwinworking locally and was able to debug the build failures. Could you confirm that this works for you @Chickenkeeper? I don't want to clear CI caches because that might make builds fail.