Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tui: Allow toggling mouse capture at runtime #6675

Merged
merged 1 commit into from
Apr 21, 2023
Merged

tui: Allow toggling mouse capture at runtime #6675

merged 1 commit into from
Apr 21, 2023

Conversation

the-mikedavis
Copy link
Member

@the-mikedavis the-mikedavis commented Apr 9, 2023 •
edited
Loading

This picks up changes to the editor.mouse option at runtime - either through :set-option or :config-reload. When the value changes, we tell the terminal to enable or disable mouse capture sequences.

Closes #6638
Closes #5648
Closes #5931

@the-mikedavis
tui: Allow toggling mouse capture at runtime
3423a8a 
This picks up changes to the `editor.mouse` option at runtime - either
through `:set-option` or `:config-reload`. When the value changes, we
tell the terminal to enable or disable mouse capture sequences.
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 9, 2023
@pascalkuthe
Copy link
Member

I think this supercedes #5931 (and therefore closes #5648) IIRC

pascalkuthe
pascalkuthe approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@archseer archseer merged commit ee7413a into master Apr 21, 2023
@archseer archseer deleted the toggle-mouse-capture-at-runtime branch April 21, 2023 03:53
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@the-mikedavis @Triton171
tui: Allow toggling mouse capture at runtime (helix-editor#6675)
27f7ec4 
This picks up changes to the `editor.mouse` option at runtime - either
through `:set-option` or `:config-reload`. When the value changes, we
tell the terminal to enable or disable mouse capture sequences.
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@the-mikedavis @wes-adams
tui: Allow toggling mouse capture at runtime (helix-editor#6675)
39c962a 
This picks up changes to the `editor.mouse` option at runtime - either
through `:set-option` or `:config-reload`. When the value changes, we
tell the terminal to enable or disable mouse capture sequences.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@the-mikedavis
tui: Allow toggling mouse capture at runtime (helix-editor#6675)
9739949 
This picks up changes to the `editor.mouse` option at runtime - either
through `:set-option` or `:config-reload`. When the value changes, we
tell the terminal to enable or disable mouse capture sequences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
3 participants
@the-mikedavis @pascalkuthe @archseer