Add undercurl config option #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpttrssn
changed the title
pascalkuthe
previously approved these changes
Mar 10, 2023
pascalkuthe
added
E-easy
|
Looks like you forgot to update some function arguments in tests @jpttrssn sorry I forgot about tests and didn't wait for CI to finish before posting my review |
If set to 'true' this option will force terminal undercurl support.
jpttrssn
force-pushed
the
undercurl-config
branch
from
67b4b4e to
7f44238
Compare
|
I think I've fixed the tests. I didn't know how to run them! I created a PR that updates the contributing documentation on how to run tests for Rust newbies like myself. #6268 |
jpttrssn
requested review from
pascalkuthe
and removed request for
the-mikedavis
archseer
approved these changes
Mar 14, 2023
sagnibak
pushed a commit
to sagnibak/helix
that referenced
this pull request
Mar 21, 2023
If set to 'true' this option will force terminal undercurl support.
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
If set to 'true' this option will force terminal undercurl support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6196. If set to 'true' this option will force terminal undercurl support.
I don't have ArchLinux so tested this by setting
undercurl = truein my config file and running a version of helix wherehas_extended_underlineswas only set by the config option.I didn't find any related integration tests that could help me in writing one for this. If needed (and someone can point me in the right direction) I may be able to add that as well.