-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade git-repository
to gix
0.36.1; up min. rustc version to 1.64
#6065
Conversation
This fixes breakage when installing `helix` due to an incorrect usage of `as_ref()` when interacting with `bstr` in the `gitoxide` codebase. However, this upgrade also requires a higher rustc version, as `gitoxide` recently updated its `windows` crate version.
We currently have a MSRV of 1.63 (on purpose) and hence we can't update. Ubuntu is really annoying at the moment tough because they supposedly update their rustc version to match those of firefox: https://wiki.ubuntu.com/FoundationsTeam/RustUpdates However at the moment rustc 1.65 is not yet in the ubuntu repos even tough firefox 110 is which requires rustc 1.65 (see https://changelogs.ubuntu.com/changelogs/pool/main/f/firefox/firefox_110.0+build3-0ubuntu0.20.04.1/changelog). The last time the firefox and rustc update happen simultaneously. The update to firefox 110 just happened 12 hours ago so lets hope that the update happens soon. That being said the issue in GitoxideLabs/gitoxide#747 only occurs because the install instructions from the manual were not followed. Helix should be install with |
Thanks for the update! Indeed, let's hope that the new rustc release will make it into the distro soon so this can move on. Also, it's good to hear that |
Co-authored-by: Ivan Tham <pickfire@riseup.net>
Thanks for the clarification. Weird that |
Closing in favor #6185 which includes this PR. |
This fixes breakage when installing
helix
due to an incorrect usage ofas_ref()
when interacting withbstr
in thegitoxide
codebase.However, this upgrade also requires a higher rustc version, as
gitoxide
recently updated itswindows
crate version.